[heap] Refactor incremental marking step.

[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO

Committed: https://crrev.com/eca8a5ebbdab6b3276fca3abead893fd721336a0
Cr-Commit-Position: refs/heads/master@{#39213}

[ulan, 2016-09-02 12:48:21]

Description was changed from

==========
[heap] Refactor incremental marking step.

This extracts the logic of keeping track of allocated bytes from the
actual incremental marking step.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- removes OldSpaceStep.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

[ulan, 2016-09-02 12:58:21]

Description was changed from

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- removes OldSpaceStep.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

[ulan, 2016-09-02 12:59:39]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-09-02 12:59:40]

ptal

https://codereview.chromium.org/2304123003/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2304123003/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:1202: if (state_ == SWEEPING) {
All changes below are just moves except for kStepSizeInMs in 1221

[Michael Lippautz, 2016-09-02 19:05:19]

lgtm % one comment

https://codereview.chromium.org/2304123003/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2304123003/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:1202: if (state_ == SWEEPING) {
On 2016/09/02 12:59:40, ulan wrote:
> All changes below are just moves except for kStepSizeInMs in 1221

Acknowledged. Awesome that we can reuse the constant.

https://codereview.chromium.org/2304123003/diff/80001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2304123003/diff/80001/src/heap/spaces.cc#newc...
src/heap/spaces.cc:2498: Heap::kNoGCFlags, kNoGCCallbackFlags, "old space
step");
Previously this would also do a step if marking has already been started. Can
you explain why is it ok to delay progress here?

[ulan, 2016-09-05 08:02:23]

https://codereview.chromium.org/2304123003/diff/80001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2304123003/diff/80001/src/heap/spaces.cc#newc...
src/heap/spaces.cc:2498: Heap::kNoGCFlags, kNoGCCallbackFlags, "old space
step");
On 2016/09/02 19:05:19, Michael Lippautz wrote:
> Previously this would also do a step if marking has already been started. Can
> you explain why is it ok to delay progress here?

Marking progress is ensured by the allocation observer. Doing step here kind of
duplicates that mechanism. Removing it for simplicity.

[ulan, 2016-09-05 11:06:15]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-09-05 11:06:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 11:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 11:23:51]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ulan, 2016-09-06 12:38:18]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-06 12:38:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2304123003/#ps100001
(title: "fix assert in SimulateIncrementalMarking")

[commit-bot: I haz the power, 2016-09-06 12:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 12:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:56:36]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ulan, 2016-09-06 14:26:50]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-06 14:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2304123003/#ps120001
(title: "fix sweeping in test")

[commit-bot: I haz the power, 2016-09-06 14:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 14:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 14:43:34]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ulan, 2016-09-06 14:55:05]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-06 14:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2304123003/#ps140001
(title: "another fix of the test")

[commit-bot: I haz the power, 2016-09-06 14:55:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 15:28:58]

Description was changed from

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

[commit-bot: I haz the power, 2016-09-06 15:28:59]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-06 15:29:28]

Description was changed from

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] Refactor incremental marking step.

This patch
- extracts the logic of keeping track of allocated bytes
  from the actual incremental marking step.
- replaces OldSpaceStep with a check for incremental marking start.
- removes the force_marking parameter of AdvanceIncrementalMarking.

BUG=chromium:616434
LOG=NO

Committed: https://crrev.com/eca8a5ebbdab6b3276fca3abead893fd721336a0
Cr-Commit-Position: refs/heads/master@{#39213}
==========

[commit-bot: I haz the power, 2016-09-06 15:29:29]

Patchset 8 (id:??) landed as
https://crrev.com/eca8a5ebbdab6b3276fca3abead893fd721336a0
Cr-Commit-Position: refs/heads/master@{#39213}