Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2304113002:
Disabling v8.todoMVC tests on reference builds (Closed)
DescriptionDisabling v8.todoMVC tests on reference builds
BUG=636405
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/0de9faf1af255a6e7d928ee4c65eb0214ce72a3e
Cr-Commit-Position: refs/heads/master@{#416270}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Disabling v8.todoMVC tests on reference builds BUG=636405 ========== to ========== Disabling v8.todoMVC tests on reference builds BUG=636405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
picksi@chromium.org changed reviewers: + picksi@chromium.org, skyostil@chromium.org
Sami, can you take a look at this and give it an LGTM if you're happy with it.
lgtm. Interesting that these are only failing on the reference builds...
The CQ bit was checked by picksi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
NOTRY=true
The CQ bit was checked by picksi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by picksi@chromium.org
Description was changed from ========== Disabling v8.todoMVC tests on reference builds BUG=636405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling v8.todoMVC tests on reference builds BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by picksi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disabling v8.todoMVC tests on reference builds BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling v8.todoMVC tests on reference builds BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disabling v8.todoMVC tests on reference builds BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling v8.todoMVC tests on reference builds BUG=636405 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/0de9faf1af255a6e7d928ee4c65eb0214ce72a3e Cr-Commit-Position: refs/heads/master@{#416270} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0de9faf1af255a6e7d928ee4c65eb0214ce72a3e Cr-Commit-Position: refs/heads/master@{#416270}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2313143002/ by lpy@chromium.org. The reason for reverting is: Enable v8.todoMVC tests on reference builds since they won't fail on TOT now.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
