Issue 23041002: Improve 'XMLHttpRequest' exception messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23041002: Improve 'XMLHttpRequest' exception messages. (Closed)

Created:
7 years, 4 months ago by Mike West

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Improve 'XMLHttpRequest' exception messages. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156212

Patch Set 1 #

Patch Set 2 : rebaseline. #

Patch Set 3 : ExceptionMessages. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -269 lines)			Patch
M	LayoutTests/fast/files/apply-blob-url-to-xhr-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/js/dfg-custom-getter-throw-expected.txt	View	1 2	1 chunk	+100 lines, -100 lines	0 comments	Download
M	LayoutTests/fast/js/dfg-custom-getter-throw-inlined-expected.txt	View	1 2	1 chunk	+100 lines, -100 lines	0 comments	Download
M	LayoutTests/fast/js/script-tests/dfg-custom-getter-throw.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/js/script-tests/dfg-custom-getter-throw-inlined.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responseXML-xml-text-responsetype-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/exceptions-expected.txt	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/inject-header-expected.txt	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain-expected.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-open-empty-method-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-name-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/xmlhttprequest/zero-length-response-expected.txt	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/ExceptionMessages.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/ExceptionMessages.cpp	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View	1 2	17 chunks	+26 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23041002/8001

7 years, 4 months ago (2013-08-16 09:29:23 UTC) #3

Message was sent while issue was closed.

Change committed as 156212

Expand Messages | Collapse Messages