Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2304093002: [turbofan] Make field indices explicit for LoadElimination. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make field indices explicit for LoadElimination. This makes it easier to read and maintain this code. R=epertoso@chromium.org Committed: https://crrev.com/20bc88dc4f655120162997017369cabc2ce20d08 Cr-Commit-Position: refs/heads/master@{#39127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -25 lines) Patch
M src/compiler/load-elimination.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 10 chunks +51 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-02 10:33:36 UTC) #1
epertoso
lgtm
4 years, 3 months ago (2016-09-02 10:45:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304093002/1
4 years, 3 months ago (2016-09-02 10:46:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 10:56:29 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 10:57:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20bc88dc4f655120162997017369cabc2ce20d08
Cr-Commit-Position: refs/heads/master@{#39127}

Powered by Google App Engine
This is Rietveld 408576698