Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Side by Side Diff: content/browser/time_zone_monitor.h

Issue 2304073003: Mojoify time zone update IPC from browser to renderer (Closed)
Patch Set: nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_TIME_ZONE_MONITOR_H_ 5 #ifndef CONTENT_BROWSER_TIME_ZONE_MONITOR_H_
6 #define CONTENT_BROWSER_TIME_ZONE_MONITOR_H_ 6 #define CONTENT_BROWSER_TIME_ZONE_MONITOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "device/time/public/interfaces/time_zone_monitor.mojom.h"
12 #include "mojo/public/cpp/bindings/binding_set.h"
11 13
12 namespace content { 14 namespace content {
13 15
14 // TimeZoneMonitor watches the system time zone, and notifies renderers 16 // TimeZoneMonitor watches the system time zone, and notifies renderers
15 // when it changes. Some renderer code caches the system time zone, so 17 // when it changes. Some renderer code caches the system time zone, so
16 // this notification is necessary to inform such code that cached 18 // this notification is necessary to inform such code that cached
17 // timezone data may have become invalid. Due to sandboxing, it is not 19 // timezone data may have become invalid. Due to sandboxing, it is not
18 // possible for renderer processes to monitor for system time zone 20 // possible for renderer processes to monitor for system time zone
19 // changes themselves, so this must happen in the browser process. 21 // changes themselves, so this must happen in the browser process.
20 // 22 //
21 // Sandboxing also may prevent renderer processes from reading the time 23 // Sandboxing also may prevent renderer processes from reading the time
22 // zone when it does change, so platforms may have to deal with this in 24 // zone when it does change, so platforms may have to deal with this in
23 // platform-specific ways: 25 // platform-specific ways:
24 // - Mac uses a sandbox hole defined in content/renderer/renderer.sb. 26 // - Mac uses a sandbox hole defined in content/renderer/renderer.sb.
25 // - Linux-based platforms use ProxyLocaltimeCallToBrowser in 27 // - Linux-based platforms use ProxyLocaltimeCallToBrowser in
26 // content/zygote/zygote_main_linux.cc and HandleLocaltime in 28 // content/zygote/zygote_main_linux.cc and HandleLocaltime in
27 // content/browser/renderer_host/sandbox_ipc_linux.cc to override 29 // content/browser/renderer_host/sandbox_ipc_linux.cc to override
28 // localtime in renderer processes with custom code that calls 30 // localtime in renderer processes with custom code that calls
29 // localtime in the browser process via Chrome IPC. 31 // localtime in the browser process via Chrome IPC.
30 32
31 class TimeZoneMonitor { 33 // TODO(blundell): Update this class to be named TimeZoneMonitorImpl.
jam 2016/09/06 22:11:18 nit: btw no need to do that. the reason interfaces
blundell 2016/09/07 14:40:05 Ah convenient.
34 class TimeZoneMonitor : public device::mojom::TimeZoneMonitor {
32 public: 35 public:
33 // Returns a new TimeZoneMonitor object (likely a subclass) specific to the 36 // Returns a new TimeZoneMonitor object (likely a subclass) specific to the
34 // platform. 37 // platform.
35 static std::unique_ptr<TimeZoneMonitor> Create(); 38 static std::unique_ptr<TimeZoneMonitor> Create();
36 39
37 virtual ~TimeZoneMonitor(); 40 ~TimeZoneMonitor() override;
41
42 void Bind(device::mojom::TimeZoneMonitorRequest request);
38 43
39 protected: 44 protected:
40 TimeZoneMonitor(); 45 TimeZoneMonitor();
41 46
42 // Loop over all renderers and notify them that the system time zone may 47 // Notify all callbacks that the system time zone may have changed.
43 // have changed. 48 void NotifyClients();
44 void NotifyRenderers();
45 49
46 private: 50 private:
51 // device::mojom::device::mojom::TimeZoneMonitor:
52 void QueryNextTimeZoneChange(
53 const device::mojom::TimeZoneMonitor::QueryNextTimeZoneChangeCallback&
54 callback) override;
55
56 mojo::BindingSet<device::mojom::TimeZoneMonitor> bindings_;
57 std::vector<device::mojom::TimeZoneMonitor::QueryNextTimeZoneChangeCallback>
58 on_time_zone_change_tasks_;
47 DISALLOW_COPY_AND_ASSIGN(TimeZoneMonitor); 59 DISALLOW_COPY_AND_ASSIGN(TimeZoneMonitor);
48 }; 60 };
49 61
50 } // namespace content 62 } // namespace content
51 63
52 #endif // CONTENT_BROWSER_TIME_ZONE_MONITOR_H_ 64 #endif // CONTENT_BROWSER_TIME_ZONE_MONITOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698