Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: third_party/WebKit/Source/web/WebLeakDetector.cpp

Issue 2304073002: LeakDetector should run a GC on the compositor thread (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLeakDetector.cpp
diff --git a/third_party/WebKit/Source/web/WebLeakDetector.cpp b/third_party/WebKit/Source/web/WebLeakDetector.cpp
index b9e99e0aa74ce7cedd2b277982534a10bd70722d..660caf20438de9ea4ecb160d3f46910e4567b2e2 100644
--- a/third_party/WebKit/Source/web/WebLeakDetector.cpp
+++ b/third_party/WebKit/Source/web/WebLeakDetector.cpp
@@ -36,6 +36,7 @@
#include "core/inspector/InstanceCounters.h"
#include "core/workers/InProcessWorkerMessagingProxy.h"
#include "core/workers/WorkerThread.h"
+#include "modules/compositorworker/AbstractAnimationWorkletThread.h"
#include "platform/Timer.h"
#include "public/web/WebFrame.h"
#include "web/WebLocalFrameImpl.h"
@@ -105,6 +106,7 @@ void WebLeakDetectorImpl::prepareForLeakDetection(WebFrame* frame)
void WebLeakDetectorImpl::collectGarbageAndReport()
{
V8GCController::collectAllGarbageForTesting(V8PerIsolateData::mainThreadIsolate());
+ AbstractAnimationWorkletThread::collectAllGarbage();
// Note: Oilpan precise GC is scheduled at the end of the event loop.
// Task queue may contain delayed object destruction tasks.
@@ -122,6 +124,7 @@ void WebLeakDetectorImpl::delayedGCAndReport(TimerBase*)
// The third GC is necessary for cleaning up Document after worker object died.
V8GCController::collectAllGarbageForTesting(V8PerIsolateData::mainThreadIsolate());
+ AbstractAnimationWorkletThread::collectAllGarbage();
// Note: Oilpan precise GC is scheduled at the end of the event loop.
// Inspect counters on the next event loop.
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698