Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2304063002: Revert "Avoid to use environment." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from recipe_engine import recipe_api 7 from recipe_engine import recipe_api
8 from recipe_engine import util as recipe_util 8 from recipe_engine import util as recipe_util
9 9
10 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder): 10 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 '--show-path', 170 '--show-path',
171 'python', 171 'python',
172 self.package_repo_resource('scripts', 'slave', 'compile.py'), 172 self.package_repo_resource('scripts', 'slave', 'compile.py'),
173 '--gsutil-py-path', self.m.depot_tools.gsutil_py_path, 173 '--gsutil-py-path', self.m.depot_tools.gsutil_py_path,
174 '--ninja-path', self.m.depot_tools.ninja_path, 174 '--ninja-path', self.m.depot_tools.ninja_path,
175 '--target', target or self.c.build_config_fs, 175 '--target', target or self.c.build_config_fs,
176 '--src-dir', self.m.path['checkout'], 176 '--src-dir', self.m.path['checkout'],
177 '--goma-cache-dir', self.m.path['goma_cache'], 177 '--goma-cache-dir', self.m.path['goma_cache'],
178 ] 178 ]
179 179
180 # Set some buildbot info used in goma_utils.
181 for key in ['buildername', 'mastername', 'slavename', 'clobber']:
182 if key in self.m.properties:
183 args.extend([
184 '--buildbot-%s' % key, self.m.properties[key]
185 ])
186
187 # Use explicit goma deps cache dir if it's set in the path config. 180 # Use explicit goma deps cache dir if it's set in the path config.
188 # Otherwise use the default one inside build output directory. 181 # Otherwise use the default one inside build output directory.
189 try: 182 try:
190 args.extend(['--goma-deps-cache-dir', self.m.path['goma_deps_cache']]) 183 args.extend(['--goma-deps-cache-dir', self.m.path['goma_deps_cache']])
191 except KeyError: 184 except KeyError:
192 pass 185 pass
193 186
194 if self.c.compile_py.build_args: 187 if self.c.compile_py.build_args:
195 args += ['--build-args', self.c.compile_py.build_args] 188 args += ['--build-args', self.c.compile_py.build_args]
196 if self.m.properties.get('build_data_dir'): 189 if self.m.properties.get('build_data_dir'):
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 })) 795 }))
803 796
804 def get_annotate_by_test_name(self, test_name): 797 def get_annotate_by_test_name(self, test_name):
805 return 'graphing' 798 return 'graphing'
806 799
807 def download_lto_plugin(self): 800 def download_lto_plugin(self):
808 return self.m.python( 801 return self.m.python(
809 name='download LTO plugin', 802 name='download LTO plugin',
810 script=self.m.path['checkout'].join( 803 script=self.m.path['checkout'].join(
811 'build', 'download_gold_plugin.py')) 804 'build', 'download_gold_plugin.py'))
OLDNEW
« no previous file with comments | « scripts/slave/goma_utils.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698