Issue 230403003: [CSS Shapes] large corner radius combined with 0 radius does not wrap properly

Issue 230403003: [CSS Shapes] large corner radius combined with 0 radius does not wrap properly (Closed)

Created:
6 years, 8 months ago by rwlbuis

Modified:
6 years, 8 months ago

Reviewers:
Hans Muller, eseidel

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

[CSS Shapes] large corner radius combined with 0 radius does not wrap properly Corrected special case handling for shape-outside border-box values with border-radius values that greater than or equal to the box's height. This is a merge of http://trac.webkit.org/changeset/166966 by Hans Muller <hmuller@adobe.com>;. BUG=361329 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171173

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -5 lines)			Patch
A	LayoutTests/fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001-expected.txt	View		1 chunk	+10 lines, -4 lines	0 comments	Download
A	LayoutTests/fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002-expected.html	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	Source/core/rendering/shapes/BoxShape.cpp	View		2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 10 (0 generated)

Hans Muller

On 2014/04/09 16:02:33, rwlbuis wrote: > PTAL :) The tests should use the unprefixed shape ...

6 years, 8 months ago (2014-04-09 16:27:33 UTC) #2

rwlbuis

On 2014/04/09 16:27:33, Hans Muller wrote: > On 2014/04/09 16:02:33, rwlbuis wrote: > > PTAL ...

6 years, 8 months ago (2014-04-09 16:51:29 UTC) #3

rwlbuis

PTAL. When this goes in we'll be able to close long standing issue 322165 :)

6 years, 8 months ago (2014-04-09 16:58:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/230403003/20001

6 years, 8 months ago (2014-04-09 17:23:51 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/230403003/20001

6 years, 8 months ago (2014-04-09 20:14:35 UTC) #9

Message was sent while issue was closed.

Change committed as 171173