Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 2304023003: StackFrameDepth should be managed per ThreadHeap (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/Visitor.h
diff --git a/third_party/WebKit/Source/platform/heap/Visitor.h b/third_party/WebKit/Source/platform/heap/Visitor.h
index 9873523d64c1efc0002dcd7c92b815fccfac82c6..128ad4f51fac5f1cc08bd72ffdc87caeeeeecb32 100644
--- a/third_party/WebKit/Source/platform/heap/Visitor.h
+++ b/third_party/WebKit/Source/platform/heap/Visitor.h
@@ -33,6 +33,7 @@
#include "platform/PlatformExport.h"
#include "platform/heap/GarbageCollected.h"
+#include "platform/heap/StackFrameDepth.h"
#include "wtf/Allocator.h"
#include "wtf/Assertions.h"
#include "wtf/Forward.h"
@@ -117,7 +118,7 @@ public:
// VisitorHelper avoids virtual methods by using CRTP.
// c.f. http://en.wikipedia.org/wiki/Curiously_Recurring_Template_Pattern
template<typename Derived>
-class VisitorHelper {
+class VisitorHelper : public StackFrameDepth {
haraken 2016/09/06 13:03:11 This looks like a weird class design. This is oka
public:
VisitorHelper(ThreadState* state) : m_state(state) { }

Powered by Google App Engine
This is Rietveld 408576698