third_party/WebKit/Source/platform/heap/Heap.cpp - Issue 2304023003: StackFrameDepth should be managed per ThreadHeap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.cpp

Issue 2304023003: StackFrameDepth should be managed per ThreadHeap (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Heap.cpp

diff --git a/third_party/WebKit/Source/platform/heap/Heap.cpp b/third_party/WebKit/Source/platform/heap/Heap.cpp

index c6710fdbc88360ee18830cd040fec0252571ae07..1da7d21f880693c4b7cd3722f88d7d54ad42f5d1 100644

--- a/third_party/WebKit/Source/platform/heap/Heap.cpp

+++ b/third_party/WebKit/Source/platform/heap/Heap.cpp

@@ -528,7 +528,7 @@ void ThreadHeap::collectGarbage(BlinkGC::StackState stackState, BlinkGC::GCType

state->heap().commitCallbackStacks();

state->heap().preGC();

- StackFrameDepthScope stackDepthScope;

+ StackFrameDepthScope stackDepthScope(visitor.get());

size_t totalObjectSize = state->heap().heapStats().allocatedObjectSize() + state->heap().heapStats().markedObjectSize();

if (gcType != BlinkGC::TakeSnapshot)