Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/platform/heap/TraceTraits.h

Issue 2304023003: StackFrameDepth should be managed per ThreadHeap (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/TraceTraits.h
diff --git a/third_party/WebKit/Source/platform/heap/TraceTraits.h b/third_party/WebKit/Source/platform/heap/TraceTraits.h
index 5bae4425f4752d695cf3d0e2f8f3d91ccd1325b1..a79223fccff718e7b6cc0375a326c9b5e3dce50a 100644
--- a/third_party/WebKit/Source/platform/heap/TraceTraits.h
+++ b/third_party/WebKit/Source/platform/heap/TraceTraits.h
@@ -70,8 +70,8 @@ public:
// but test and appropriately handle them should they occur
// in release builds.
//
- ASSERT(StackFrameDepth::isAcceptableStackUse());
- if (LIKELY(StackFrameDepth::isSafeToRecurse())) {
+ DCHECK(visitor->heap().stackFrameDepth().isAcceptableStackUse());
+ if (LIKELY(visitor->heap().stackFrameDepth().isSafeToRecurse())) {
haraken 2016/09/02 09:07:57 I hope this won't regress performance. Moving Sta
if (visitor->ensureMarked(t)) {
TraceTrait<T>::trace(visitor, const_cast<T*>(t));
}

Powered by Google App Engine
This is Rietveld 408576698