Ensure that |Thread::id_| is only accessed when an happens-after relationship has been established …

Ensure that |Thread::id_| is only accessed when an happens-after relationship has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the function
  waits until the object is signaled or the interval elapses. If dwMilliseconds is zero,
  the function does not enter a wait state if the object is not signaled; it always returns
  immediately. If dwMilliseconds is INFINITE, the function will return only when the object
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Committed: https://crrev.com/3e09ce122b81dadacd6ffde73bee126952ff0d1f
Cr-Commit-Position: refs/heads/master@{#417117}

[gab, 2016-09-02 14:26:29]

Description was changed from

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

BUG=638578
==========

to

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

[gab, 2016-09-02 14:26:34]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 14:26:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-02 14:26:55]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-09-02 14:26:56]

Dana PTAL, thanks!

[commit-bot: I haz the power, 2016-09-02 19:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 19:20:55]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2016-09-06 21:14:42]

Should we DCHECK signaled when we look at the id_ elsewhere too, like
Thread::Run?

[gab, 2016-09-07 13:30:52]

On 2016/09/06 21:14:42, danakj wrote:
> Should we DCHECK signaled when we look at the id_ elsewhere too, like
> Thread::Run?

The current PS does add DCHECK(id_event_.IsSignaled()) to Thread::Run() so not
sure where you think it's missing?

[danakj, 2016-09-07 20:34:41]

Oops.. I thought only the header changed I have no idea what happened LGTM

[gab, 2016-09-07 20:48:00]

FYI, had to tweak AssertWaitAllowed() in waitable_event_win.cc to not assert if
wait time is zero (IsSignaled() uses TimedWait(0) on Windows).

[gab, 2016-09-07 20:54:36]

Description was changed from

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

to

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to
allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to
wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the
function
  waits until the object is signaled or the interval elapses. If dwMilliseconds
is zero, 
  the function does not enter a wait state if the object is not signaled; it
always returns 
  immediately. If dwMilliseconds is INFINITE, the function will return only when
the object 
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

[danakj, 2016-09-07 20:59:00]

LGTM thx

[gab, 2016-09-07 20:59:14]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:59:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:41:25]

Description was changed from

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to
allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to
wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the
function
  waits until the object is signaled or the interval elapses. If dwMilliseconds
is zero, 
  the function does not enter a wait state if the object is not signaled; it
always returns 
  immediately. If dwMilliseconds is INFINITE, the function will return only when
the object 
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

to

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to
allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to
wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the
function
  waits until the object is signaled or the interval elapses. If dwMilliseconds
is zero, 
  the function does not enter a wait state if the object is not signaled; it
always returns 
  immediately. If dwMilliseconds is INFINITE, the function will return only when
the object 
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

[commit-bot: I haz the power, 2016-09-07 23:41:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 23:43:18]

Description was changed from

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to
allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to
wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the
function
  waits until the object is signaled or the interval elapses. If dwMilliseconds
is zero, 
  the function does not enter a wait state if the object is not signaled; it
always returns 
  immediately. If dwMilliseconds is INFINITE, the function will return only when
the object 
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

to

==========
Ensure that |Thread::id_| is only accessed when an happens-after relationship
has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to
allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to
wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the
function
  waits until the object is signaled or the interval elapses. If dwMilliseconds
is zero,
  the function does not enter a wait state if the object is not signaled; it
always returns
  immediately. If dwMilliseconds is INFINITE, the function will return only when
the object
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Committed: https://crrev.com/3e09ce122b81dadacd6ffde73bee126952ff0d1f
Cr-Commit-Position: refs/heads/master@{#417117}
==========

[commit-bot: I haz the power, 2016-09-07 23:43:21]

Patchset 2 (id:??) landed as
https://crrev.com/3e09ce122b81dadacd6ffde73bee126952ff0d1f
Cr-Commit-Position: refs/heads/master@{#417117}