Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2303933002: Include $extra_ldflags in link descriptions. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Include $extra_ldflags in link descriptions. I overlooked this this morning. Not hugely important, but nice to see. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303933002 Committed: https://skia.googlesource.com/skia/+/233eb0adc7df47ac38eac20231f4b04e90cb0d8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gn/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 22:03:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303933002/1
4 years, 3 months ago (2016-09-01 22:03:40 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-01 22:03:41 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-02 04:03:40 UTC) #8
jcgregorio
lgtm
4 years, 3 months ago (2016-09-02 13:57:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303933002/1
4 years, 3 months ago (2016-09-02 14:12:31 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:24:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/233eb0adc7df47ac38eac20231f4b04e90cb0d8d

Powered by Google App Engine
This is Rietveld 408576698