Issue 23039013: Web Animations: Fix elpasedTime in animation events

Issue 23039013: Web Animations: Fix elpasedTime in animation events (Closed)

Created:
7 years, 4 months ago by Steve Block

Modified:
7 years, 3 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations: Fix elpasedTime in animation events This addresses the FIXME in CSSAnimations::EventDelegate::onEventCondition() to pass the TimedItem to the event callback. Also tighten up a test such that it would now detect the FIXME. BUG=240653 R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156768

Patch Set 1 #

Patch Set 2 : Update unit test #

Patch Set 3 : Updated to use time the animation has been running #

Patch Set 4 : Rebased #

Total comments: 4

Patch Set 5 : Fixed elapsedTime for negative delay and added a test #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -14 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/animations/keyframes-iteration-count-non-integer.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/animations/negative-delay-events.html	View	1 2 3 4	1 chunk	+68 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/negative-delay-events-expected.txt	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/animation/TimedItem.h	View	1 2	3 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/core/animation/TimedItem.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/TimedItemTest.cpp	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	1 2 3 4	1 chunk	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Steve Block

Ready for another look Note that this depends on https://codereview.chromium.org/23173007

7 years, 4 months ago (2013-08-21 07:33:12 UTC) #2

dstockwell

lgtm https://codereview.chromium.org/23039013/diff/13001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/23039013/diff/13001/Source/core/animation/css/CSSAnimations.cpp#newcode253 Source/core/animation/css/CSSAnimations.cpp:253: // compatitbility with the existing implementation, this event ...

7 years, 4 months ago (2013-08-22 07:32:58 UTC) #4

Steve Block

Note that the new test currently crashes with Web Animations due to an assertion failure ...

7 years, 3 months ago (2013-08-27 05:04:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23039013/18001

7 years, 3 months ago (2013-08-27 05:10:18 UTC) #7

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3231

7 years, 3 months ago (2013-08-27 06:32:22 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23039013/18001

7 years, 3 months ago (2013-08-27 06:43:39 UTC) #9

Message was sent while issue was closed.

Change committed as 156768

Expand Messages | Collapse Messages