Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 23039006: [Android] Stop-gap solution for reducing INJECT_EVENTS flakiness. (Closed)

Created:
7 years, 4 months ago by frankf
Modified:
7 years, 4 months ago
Reviewers:
craigdh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Stop-gap solution for reducing INJECT_EVENTS flakiness. Crash/ANR dialogs on Android are automatically dismissed after 5 minutes. Run content_browsertests earlier in the test cycle. BUG=271071 R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/gtest/gtest_config.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
frankf
7 years, 4 months ago (2013-08-13 22:31:45 UTC) #1
craigdh
lgtm.
7 years, 4 months ago (2013-08-13 22:34:18 UTC) #2
frankf
Committed patchset #1 manually as r217358 (presubmit successful).
7 years, 4 months ago (2013-08-13 22:43:24 UTC) #3
navabi1
7 years, 4 months ago (2013-08-14 19:14:59 UTC) #4
Message was sent while issue was closed.
On 2013/08/13 22:43:24, frankf wrote:
> Committed patchset #1 manually as r217358 (presubmit successful).

I like the plan to stop popups from showing up. I'm not a fan of this stop-gap
of just putting the tests earlier and hoping it goes away by the instrumentation
tests (i.e. another test could cause it, sharding may make the time in between
the content_browsertests less for some bots than others, etc.), but it'll do for
now as long as we have another solution coming soon. Note: the devices are
currently restarted after the unit tests and before the content_browser tests,
as another stop-gap solution for not getting INJECT_EVENTS errors before I knew
about this CL.

Powered by Google App Engine
This is Rietveld 408576698