Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2303883004:
[Remoting Client] Disable OpenGL renderer on Windows (Closed)
|
Created:
4 years, 3 months ago by Yuwei Modified:
4 years, 3 months ago Reviewers:
Sergey Ulanov CC:
Nico, chromium-reviews, chromoting-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Remoting Client] Disable OpenGL renderer on Windows
CL 2196493002 brought ANGLE libGLESv2 dependency to the remoting unittest on
Windows. For some reason the Windows clang tester built 64-bit unittest
binary but tries to link it with a 32-bit ANGLE binary. Since the OpenGL
renderer is not used on Windows anyway, we may just disable the unit test on
Windows until we figure out what went wrong with the build setup.
BUG=642027
Committed: https://crrev.com/408c95610a59dec6ff6321809b51e13eb356e064
Cr-Commit-Position: refs/heads/master@{#417440}
Patch Set 1 #Patch Set 2 : Fix build failure #
Total comments: 4
Patch Set 3 : Merge ToT #Patch Set 4 : Reviewer's Feedback #Messages
Total messages: 23 (15 generated)
The CQ bit was checked by yuweih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yuweih@chromium.org changed reviewers: + sergeyu@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yuweih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by yuweih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.gn File remoting/client/BUILD.gn (right): https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.g... remoting/client/BUILD.gn:78: if (!is_win) { I don't think you really want to disable this source set. Just remove it from remoting_unittests? https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.g... remoting/client/BUILD.gn:173: if (!is_win) { Add a comment with a bug reference to make it clear why the test is disabled.
PTAL https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.gn File remoting/client/BUILD.gn (right): https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.g... remoting/client/BUILD.gn:78: if (!is_win) { On 2016/09/08 19:57:31, Sergey Ulanov wrote: > I don't think you really want to disable this source set. Just remove it from > remoting_unittests? Done. https://codereview.chromium.org/2303883004/diff/20001/remoting/client/BUILD.g... remoting/client/BUILD.gn:173: if (!is_win) { On 2016/09/08 19:57:31, Sergey Ulanov wrote: > Add a comment with a bug reference to make it clear why the test is disabled. Done.
lgtm
On 2016/09/08 20:40:24, Sergey Ulanov wrote: > lgtm Thanks!
The CQ bit was checked by yuweih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Remoting Client] Disable OpenGL renderer on Windows CL 2196493002 brought ANGLE libGLESv2 dependency to the remoting unittest on Windows. For some reason the Windows clang tester built 64-bit unittest binary but tries to link it with a 32-bit ANGLE binary. Since the OpenGL renderer is not used on Windows anyway, we may just disable the unit test on Windows until we figure out what went wrong with the build setup. BUG=642027 ========== to ========== [Remoting Client] Disable OpenGL renderer on Windows CL 2196493002 brought ANGLE libGLESv2 dependency to the remoting unittest on Windows. For some reason the Windows clang tester built 64-bit unittest binary but tries to link it with a 32-bit ANGLE binary. Since the OpenGL renderer is not used on Windows anyway, we may just disable the unit test on Windows until we figure out what went wrong with the build setup. BUG=642027 Committed: https://crrev.com/408c95610a59dec6ff6321809b51e13eb356e064 Cr-Commit-Position: refs/heads/master@{#417440} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/408c95610a59dec6ff6321809b51e13eb356e064 Cr-Commit-Position: refs/heads/master@{#417440} |
