Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 230383002: Version 3.24.35.30 (rollback of r20375) (Closed)

Created:
6 years, 8 months ago by danno
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Version 3.24.35.30 (rollback of r20375) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -140 lines) Patch
M src/heap.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/i18n.js View 23 chunks +36 lines, -30 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/intl/break-iterator/protected-icu-internals.js View 1 chunk +15 lines, -10 lines 0 comments Download
A + test/intl/collator/protected-icu-internals.js View 1 chunk +15 lines, -10 lines 0 comments Download
A + test/intl/date-format/protected-icu-internals.js View 1 chunk +15 lines, -10 lines 0 comments Download
A + test/intl/number-format/protected-icu-internals.js View 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 8 months ago (2014-04-09 08:13:40 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-09 08:14:06 UTC) #2
danno
6 years, 8 months ago (2014-04-09 08:14:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20593.

Powered by Google App Engine
This is Rietveld 408576698