Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2303823002: DevTools: check for target being oopif prior to matching its web contents. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: check for target being oopif prior to matching its web contents. BUG=641528 TBR=dgozman Committed: https://crrev.com/71ff18e2385d68b077b081f2c98d8ee9c9b42108 Cr-Commit-Position: refs/heads/master@{#416006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
pfeldman
4 years, 3 months ago (2016-09-01 17:52:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303823002/1
4 years, 3 months ago (2016-09-01 17:52:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 18:43:40 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 18:47:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71ff18e2385d68b077b081f2c98d8ee9c9b42108
Cr-Commit-Position: refs/heads/master@{#416006}

Powered by Google App Engine
This is Rietveld 408576698