Add skia_clang_build gyp define, add -Wstring-conversion flag

gyp/common_variables.gypi

 # Copyright 2012 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   # Get ready for the ugly...
   #
   # - We have to nest our variables dictionaries multiple levels deep, so that
   #   this and other gyp files can rely on previously-set variable values in
@@ skipping 60 matching lines @@
           'skia_arch_type%': 'arm',
           'arm_version%': 7,
           'arm_neon%': 0, # neon asm files known not to work with the ios build
         },{ # skia_os is not ios
           'skia_arch_type%': 'x86',
           'arm_version%': 0,
           'arm_neon%': 0,
         }],
       ],
 
+      'skia_asan_build%': 0,
       'skia_scalar%': 'float',
       'skia_mesa%': 0,
       'skia_nv_path_rendering%': 0,
       'skia_stroke_path_rendering%': 0,
       'skia_android_path_rendering%': 0,
       'skia_texture_cache_mb_limit%': 0,
       'skia_angle%': 0,
       'skia_directwrite%': 0,
       'skia_gpu%': 1,
       'skia_osx_sdkroot%': '',
@@ skipping 19 matching lines @@
 
       # This variable allows the user to customize the optimization level used
       # by the compiler.  The user should be aware that this has different
       # meanings for different compilers and should exercise caution when
       # overriding it.
       [ 'skia_os == "win"', {
         'skia_release_optimization_level%': '<(skia_default_vs_optimization_level)',
       }, {
         'skia_release_optimization_level%': '<(skia_default_gcc_optimization_level)',
       }],
+      [ 'skia_asan_build', {
+        'skia_clang_build': 1,
+      }, {

[robertphillips, 2013/08/21 14:12:51]

Should this % be here and not above?

[borenet, 2013/08/21 14:16:01]

Building with ASAN implies that we're using Clang, so we force
skia_clang_build=1 in that case.  Otherwise, we use what's provided in
GYP_DEFINES with 0 as the default.

+        'skia_clang_build%': 0,
+      }],
     ],
 
     # Re-define all variables defined within the level-2 'variables' dict,
     # so that siblings of the level-1 'variables' dict can see them.
     'arm_version%': '<(arm_version)',
     'arm_neon%': '<(arm_neon)',
     'arm_neon_optional%': 0,
     'skia_os%': '<(skia_os)',
     'os_posix%': '<(os_posix)',
+    'skia_asan_build%': '<(skia_asan_build)',

[djsollen, 2013/08/21 14:09:37]

don't you need to define skia_clang_build here as well?

[borenet, 2013/08/21 14:16:01]

No, since skia_clang_build is already defined at this level.

     'skia_scalar%': '<(skia_scalar)',
     'skia_mesa%': '<(skia_mesa)',
     'skia_nv_path_rendering%': '<(skia_nv_path_rendering)',
     'skia_stroke_path_rendering%': '<(skia_stroke_path_rendering)',
     'skia_android_path_rendering%': '<(skia_android_path_rendering)',
     'skia_texture_cache_mb_limit%': '<(skia_texture_cache_mb_limit)',
     'skia_angle%': '<(skia_angle)',
     'skia_arch_width%': '<(skia_arch_width)',
     'skia_arch_type%': '<(skia_arch_type)',
     'skia_directwrite%': '<(skia_directwrite)',
     'skia_gpu%': '<(skia_gpu)',
     'skia_win_exceptions%': 0,
     'skia_osx_sdkroot%': '<(skia_osx_sdkroot)',
     'skia_profile_enabled%': '<(skia_profile_enabled)',
     'skia_shared_lib%': '<(skia_shared_lib)',
     'skia_opencl%': '<(skia_opencl)',
     'skia_static_initializers%': '<(skia_static_initializers)',
     'ios_sdk_version%': '6.0',
     'skia_win_debuggers_path%': '<(skia_win_debuggers_path)',
-    'skia_asan_build%': 0,
 
     # These are referenced by our .gypi files that list files (e.g. core.gypi)
     #
     'skia_src_path%': '../src',
     'skia_include_path%': '../include',
   },
 }
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: