Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: Source/web/WebSettingsImpl.h

Issue 23038013: [Android WebView] Avoid expanding layout width to match the old WebView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created a separate setting Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebSettingsImpl.h
diff --git a/Source/web/WebSettingsImpl.h b/Source/web/WebSettingsImpl.h
index 6c0d2521b99f90a990ba8c5ee6f9dbe51191d845..42906f462ca56cb4bd70025084c3616e44eee7ba 100644
--- a/Source/web/WebSettingsImpl.h
+++ b/Source/web/WebSettingsImpl.h
@@ -93,6 +93,7 @@ public:
virtual void setEditingBehavior(EditingBehavior);
virtual void setEnableScrollAnimator(bool);
virtual void setEnableTouchAdjustment(bool);
+ virtual void setExpandLayoutToFillVisualViewport(bool);
kenneth.r.christiansen 2013/08/27 17:42:21 As this is a Quirk can be append Quirk?
mnaganov (inactive) 2013/08/27 18:16:51 I have no problem with adding it, although, I woul
aelias_OOO_until_Jul13 2013/08/28 21:26:47 Adding "Quirk" sounds fine to me. Maybe name it V
mnaganov (inactive) 2013/08/29 12:09:54 Done.
virtual void setExperimentalCSSCustomFilterEnabled(bool);
virtual void setRegionBasedColumnsEnabled(bool);
virtual void setCSSStickyPositionEnabled(bool);
@@ -179,6 +180,7 @@ public:
bool doubleTapToZoomEnabled() const { return m_doubleTapToZoomEnabled; }
bool perTilePaintingEnabled() const { return m_perTilePaintingEnabled; }
bool supportDeprecatedTargetDensityDPI() const { return m_supportDeprecatedTargetDensityDPI; }
+ bool expandLayoutToFillVisualViewport() const { return m_expandLayoutToFillVisualViewport; }
int pinchOverlayScrollbarThickness() const { return m_pinchOverlayScrollbarThickness; }
private:
@@ -192,6 +194,10 @@ private:
bool m_doubleTapToZoomEnabled;
bool m_perTilePaintingEnabled;
bool m_supportDeprecatedTargetDensityDPI;
+ // This quirk is to maintain compatibility with Android apps built on
+ // the Android SDK prior to and including version 18. Presumably, this
+ // can be removed any time after 2015. See http://crbug.com/277369.
+ bool m_expandLayoutToFillVisualViewport;
kenneth.r.christiansen 2013/08/27 17:42:21 *Quirk
int m_pinchOverlayScrollbarThickness;
};

Powered by Google App Engine
This is Rietveld 408576698