Issue 23038003: Eliminated manual allocation folding in BuildCloneShallowArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23038003: Eliminated manual allocation folding in BuildCloneShallowArray. (Closed)

Created:
7 years, 4 months ago by Hannes Payer (out of office)

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Eliminated manual allocation folding in BuildCloneShallowArray. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16359

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	src/hydrogen.cc	View	1 2	2 chunks	+11 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with two nits to address. https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1683 src/hydrogen.cc:1683: // Allocate both ...

7 years, 4 months ago (2013-08-16 20:02:11 UTC) #2

Hannes Payer (out of office)

Committed patchset #3 manually as r16359 (presubmit successful).

7 years, 3 months ago (2013-08-27 13:40:37 UTC) #3

Hannes Payer (out of office)

7 years, 3 months ago (2013-08-28 13:10:59 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1683
src/hydrogen.cc:1683: // Allocate both the JS array and the elements array in
one big
On 2013/08/16 20:02:11, Michael Starzinger wrote:
> nit: Comment is outdated.

Done.

https://codereview.chromium.org/23038003/diff/3001/src/hydrogen.cc#newcode1706
src/hydrogen.cc:1706: // Get hold of the elements array of the boilerplate and
setup the
On 2013/08/16 20:02:11, Michael Starzinger wrote:
> nit: Comment is outdated.

Done.

Expand Messages | Collapse Messages

Issue 23038003: Eliminated manual allocation folding in BuildCloneShallowArray. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages