Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2303773002: Align reference box computation for inline boxes with Gecko (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align reference box computation for inline boxes with Gecko For inline boxes, the reference box should be computed per-fragment, and be subject to box-decoration-break. We're not quite there yet though, so go for "local compat" for now and align with Gecko. This way we're slightly closer to "correct" (the "single line" case ought to be fairly correct for instance), and hopefully avoid getting sucked into a compat "sinkhole". Adjust css3/masking/clip-path-reference-box-inline.html to match. BUG=641907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/10b60639752dde3f81bc82323f70eb6e99adeae5 Cr-Commit-Position: refs/heads/master@{#416264}

Patch Set 1 #

Patch Set 2 : Adjust TC for Win #

Patch Set 3 : Maybe now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-inline.html View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-inline-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
fs
4 years, 3 months ago (2016-09-01 16:28:46 UTC) #5
Stephen Chennney
LGTM. Thanks for slogging through this.
4 years, 3 months ago (2016-09-02 14:47:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303773002/40001
4 years, 3 months ago (2016-09-02 14:48:58 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 14:52:34 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 14:54:00 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10b60639752dde3f81bc82323f70eb6e99adeae5
Cr-Commit-Position: refs/heads/master@{#416264}

Powered by Google App Engine
This is Rietveld 408576698