third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp - Issue 2303753003: [Fetch API] Start reading blob only when the reader wants to read contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

Issue 2303753003: [Fetch API] Start reading blob only when the reader wants to read contents. (Closed)

Patch Set: fix tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

index ae801dc1223209fdaffef48804a85e59d2d37bd2..b92de7efbeb47128ed2210f2f7e762956f75a75a 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

@@ -401,7 +401,6 @@ TEST_F(FetchFormDataConsumerHandleTest, ZeroByteReadDoesNotAffectDrainingForComp

size_t readSize;

EXPECT_EQ(kShouldWait, reader->read(nullptr, 0, kNone, &readSize));

testing::runPendingTasks();

- EXPECT_EQ(kOk, reader->read(nullptr, 0, kNone, &readSize));

hiroshige 2016/09/07 09:38:03 Why this line is removed?

yhirano 2016/09/07 11:03:24 My change makes this read return kShouldWait, and

RefPtr<EncodedFormData> formData = reader->drainAsFormData();

ASSERT_TRUE(formData);

EXPECT_TRUE(formData->isSafeToSendToAnotherThread());

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp ('k') | no next file » | no next file with comments »