Eliminate spurious request cancelations

Eliminate spurious request cancelations

This fixes the situation where every request is canceled even after it
has completed successfully.  The cancels were not harming anything and
were dropped on the floor but the additional messages were useless.

BUG=642172
Committed: https://crrev.com/8b3bca182ef878e7f6579bc067dbfae85887e521
Cr-Commit-Position: refs/heads/master@{#417565}

[Pat Meenan, 2016-09-02 14:22:44]

The CQ bit was checked by pmeenan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 14:23:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 15:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 15:33:30]

Dry run: This issue passed the CQ dry run.

[Pat Meenan, 2016-09-02 18:17:47]

pmeenan@chromium.org changed reviewers:
+ kinuko@chromium.org, rdsmith@chromium.org

[Pat Meenan, 2016-09-02 18:17:47]

rdsmith@chromium.org: PTAL as discussed in the bug.

kinuko@chromium.org: Please look at the web_url_loader_impl change and make sure
I'm correctly preventing cancels for completed requests.  It doesn't look like
the request_id_ is used or passed externally so I think it's correct but would
love another set of eyes.

[Randy Smith (Not in Mondays), 2016-09-02 18:44:33]

content/browser/loader LGTM.  Thanks!

[kinuko, 2016-09-05 15:16:51]

Looks right to me at least for what we're observing around this issue.  LGTM,
thanks!

[Pat Meenan, 2016-09-05 21:15:21]

The CQ bit was checked by pmeenan@chromium.org

[commit-bot: I haz the power, 2016-09-05 21:15:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 21:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 21:26:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Pat Meenan, 2016-09-06 14:52:22]

The CQ bit was checked by pmeenan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 14:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 15:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:22:05]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Pat Meenan, 2016-09-06 16:05:07]

The CQ bit was checked by pmeenan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 16:05:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 16:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:24:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pat Meenan, 2016-09-07 13:03:32]

Patchset #4 (id:60001) has been deleted

[Pat Meenan, 2016-09-07 13:03:51]

The CQ bit was checked by pmeenan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pat Meenan, 2016-09-07 13:15:53]

Patchset #4 (id:80001) has been deleted

[Pat Meenan, 2016-09-07 13:16:35]

The CQ bit was checked by pmeenan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 14:02:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:02:01]

Dry run: This issue passed the CQ dry run.

[Pat Meenan, 2016-09-07 15:14:43]

kinuoko@ could you please take a look at the updated changes?  Specifically I
moved the logic lower so that resource dispatcher still gets cancelled and
cleans things up on the renderer side but it doesn't send the cancel IPC through
to net if the request already completed.

[kinuko, 2016-09-09 07:45:34]

On 2016/09/07 15:14:43, Pat Meenan wrote:
> kinuoko@ could you please take a look at the updated changes?  Specifically I
> moved the logic lower so that resource dispatcher still gets cancelled and
> cleans things up on the renderer side but it doesn't send the cancel IPC
through
> to net if the request already completed.

Hmm, right we still need to perform cleanup in the renderer side.  lgtm

[Pat Meenan, 2016-09-09 11:23:57]

The CQ bit was checked by pmeenan@chromium.org

[Pat Meenan, 2016-09-09 11:23:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/2303733004/#ps100001
(title: "Fixed dispatcher unit test")

[commit-bot: I haz the power, 2016-09-09 11:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 12:26:13]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-09-09 12:28:58]

Description was changed from

==========
Eliminate spurious request cancelations

This fixes the situation where every request is canceled even after it
has completed successfully.  The cancels were not harming anything and
were dropped on the floor but the additional messages were useless.

BUG=642172
==========

to

==========
Eliminate spurious request cancelations

This fixes the situation where every request is canceled even after it
has completed successfully.  The cancels were not harming anything and
were dropped on the floor but the additional messages were useless.

BUG=642172

Committed: https://crrev.com/8b3bca182ef878e7f6579bc067dbfae85887e521
Cr-Commit-Position: refs/heads/master@{#417565}
==========

[commit-bot: I haz the power, 2016-09-09 12:28:59]

Patchset 4 (id:??) landed as
https://crrev.com/8b3bca182ef878e7f6579bc067dbfae85887e521
Cr-Commit-Position: refs/heads/master@{#417565}