Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2303733003: Add some required packages to tools/install_dependencies.sh (Closed)

Created:
4 years, 3 months ago by tikuta
Modified:
4 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add some required packages to tools/install_dependencies.sh https://skia.org/user/quick/linux I added following to build skia library. * freeglut3-dev * libglu1-mesa-dev * libosmesa6-dev Minor: * fix indent * sort package list in alphabetical order BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303733003 Committed: https://skia.googlesource.com/skia/+/d9ee597ce06ede5eb87190f45473404a08d46e52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M tools/install_dependencies.sh View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tikuta
4 years, 3 months ago (2016-09-02 06:44:45 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-09-02 11:56:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303733003/1
4 years, 3 months ago (2016-09-02 11:56:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d9ee597ce06ede5eb87190f45473404a08d46e52
4 years, 3 months ago (2016-09-02 12:21:42 UTC) #9
bsalomon
Why freeglut3-dev?
4 years, 3 months ago (2016-09-02 18:47:08 UTC) #10
tikuta
4 years, 3 months ago (2016-09-05 02:22:32 UTC) #11
Message was sent while issue was closed.
On 2016/09/02 18:47:08, bsalomon wrote:
> Why freeglut3-dev?

It is written in Prerequisites section.

Powered by Google App Engine
This is Rietveld 408576698