Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2303733002: android: Remove redundant code to suspend timers in the background (Closed)

Created:
4 years, 3 months ago by Sami
Modified:
4 years, 3 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, whywhat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove redundant code to suspend timers in the background This patch removes the Activity-side code for suspending renderer timers after 5 minutes in the background. This code is redundant because the Blink scheduler also implements this timer suspension in the renderer. BUG=637327, 379158 Committed: https://crrev.com/31abb5e88e0dc5df1788e75d5096d3a9d4ad1e0c Cr-Commit-Position: refs/heads/master@{#415951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 5 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Sami
4 years, 3 months ago (2016-09-01 13:54:26 UTC) #5
Sami
Note: we still need to keep the ViewMsg_SetWebKitSharedTimersSuspended because it's used to implement WebView's pauseTimers() ...
4 years, 3 months ago (2016-09-01 13:56:15 UTC) #6
Miguel Garcia
lgtm can you link the cl to the the original bug as well?
4 years, 3 months ago (2016-09-01 14:03:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303733002/1
4 years, 3 months ago (2016-09-01 14:08:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 14:32:36 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 14:35:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31abb5e88e0dc5df1788e75d5096d3a9d4ad1e0c
Cr-Commit-Position: refs/heads/master@{#415951}

Powered by Google App Engine
This is Rietveld 408576698