Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 230373007: Reland of r20606: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType… (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Reland of r20606: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes()). It was not related to test failures. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -114 lines) Patch
M src/elements.h View 3 chunks +2 lines, -20 lines 0 comments Download
M src/elements.cc View 20 chunks +69 lines, -94 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-09 12:51:05 UTC) #1
Yang
On 2014/04/09 12:51:05, Igor Sheludko wrote: > PTAL lgtm.
6 years, 8 months ago (2014-04-09 12:51:22 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-09 12:56:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698