macviews: always use Aura colors when --secondary-ui-md

macviews: always use Aura colors when --secondary-ui-md

BUG=642824
Committed: https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016
Cr-Commit-Position: refs/heads/master@{#416668}

[Elly Fong-Jones, 2016-09-01 13:12:45]

Description was changed from

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824
==========

to

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824
==========

[Elly Fong-Jones, 2016-09-01 13:12:45]

ellyjones@chromium.org changed reviewers:
+ estade@chromium.org

[Elly Fong-Jones, 2016-09-01 13:14:45]

estade: ptal? I'm pretty sure that we just always want the Aura color scheme
when we use --secondary-ui-md.

One issue this introduces is that we can end up falling back to pre-MD Aura
colors when there are unimplemented MD colors in Aura, like for
kColorId_HoverMenuItemBackgroundColor, so views_examples_with_content_exe looks
pretty weird with this change.

[Evan Stade, 2016-09-01 20:31:30]

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (left):

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:177: // Menus.
I suspect (but don't know for a fact) menus are going to stay the same, i.e.
platform-dependent, so maybe keep this part of the switch and fall back to the
aura color for things not handled in the switch?

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:427: return
ApplySystemControlTint(GetAuraColor(color_id, base_theme));
seems like this should be inlined now that there's only one callsite

[Elly Fong-Jones, 2016-09-02 11:34:42]

estade: ptal? :)

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (left):

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:177: // Menus.
On 2016/09/01 20:31:30, Evan Stade (ooo friday) wrote:
> I suspect (but don't know for a fact) menus are going to stay the same, i.e.
> platform-dependent, so maybe keep this part of the switch and fall back to the
> aura color for things not handled in the switch?

Hm. I changed this because the Harmony spec sheets have a page
"SPEC-secondary-UI-settings-menu" which seems to define the appearance of menus
in detail. Does that only apply to the settings menu? I actually have no idea
what the story is going to be for other menus; we've been using NSMenu on Mac,
certainly.

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:427: return
ApplySystemControlTint(GetAuraColor(color_id, base_theme));
On 2016/09/01 20:31:30, Evan Stade (ooo friday) wrote:
> seems like this should be inlined now that there's only one callsite

Well-spotted, deleted.

[Evan Stade, 2016-09-06 16:58:33]

lgtm

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (left):

https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:177: // Menus.
On 2016/09/02 11:34:42, Elly Jones wrote:
> On 2016/09/01 20:31:30, Evan Stade (ooo friday) wrote:
> > I suspect (but don't know for a fact) menus are going to stay the same, i.e.
> > platform-dependent, so maybe keep this part of the switch and fall back to
the
> > aura color for things not handled in the switch?
> 
> Hm. I changed this because the Harmony spec sheets have a page
> "SPEC-secondary-UI-settings-menu" which seems to define the appearance of
menus
> in detail. Does that only apply to the settings menu? I actually have no idea
> what the story is going to be for other menus; we've been using NSMenu on Mac,
> certainly.

That might just be included for completeness. It's probably something we should
discuss with bettes et al.

[Elly Fong-Jones, 2016-09-06 16:59:15]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 18:06:57]

Description was changed from

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824
==========

to

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824
==========

[commit-bot: I haz the power, 2016-09-06 18:06:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 18:11:26]

Description was changed from

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824
==========

to

==========
macviews: always use Aura colors when --secondary-ui-md

BUG=642824

Committed: https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016
Cr-Commit-Position: refs/heads/master@{#416668}
==========

[commit-bot: I haz the power, 2016-09-06 18:11:28]

Patchset 2 (id:??) landed as
https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016
Cr-Commit-Position: refs/heads/master@{#416668}