Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2303723003: macviews: always use Aura colors when --secondary-ui-md (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: always use Aura colors when --secondary-ui-md BUG=642824 Committed: https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016 Cr-Commit-Position: refs/heads/master@{#416668}

Patch Set 1 #

Total comments: 5

Patch Set 2 : inline GetAuraColorWithSystemTint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M ui/native_theme/native_theme_mac.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 3 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Elly Fong-Jones
estade: ptal? I'm pretty sure that we just always want the Aura color scheme when ...
4 years, 3 months ago (2016-09-01 13:14:45 UTC) #3
Evan Stade
https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm File ui/native_theme/native_theme_mac.mm (left): https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm#oldcode177 ui/native_theme/native_theme_mac.mm:177: // Menus. I suspect (but don't know for a ...
4 years, 3 months ago (2016-09-01 20:31:30 UTC) #4
Elly Fong-Jones
estade: ptal? :) https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm File ui/native_theme/native_theme_mac.mm (left): https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm#oldcode177 ui/native_theme/native_theme_mac.mm:177: // Menus. On 2016/09/01 20:31:30, Evan ...
4 years, 3 months ago (2016-09-02 11:34:42 UTC) #5
Evan Stade
lgtm https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm File ui/native_theme/native_theme_mac.mm (left): https://codereview.chromium.org/2303723003/diff/1/ui/native_theme/native_theme_mac.mm#oldcode177 ui/native_theme/native_theme_mac.mm:177: // Menus. On 2016/09/02 11:34:42, Elly Jones wrote: ...
4 years, 3 months ago (2016-09-06 16:58:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303723003/20001
4 years, 3 months ago (2016-09-06 16:59:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 18:06:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:11:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016
Cr-Commit-Position: refs/heads/master@{#416668}

Powered by Google App Engine
This is Rietveld 408576698