Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2303713002: Implement ClearHistory for all ntp_snippets providers (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index e990e6a047d58db5574260ac4a4237d1e71a620f..fabe34cbf5938f438539fdc0a6e7e513de9f25e4 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -188,7 +188,11 @@ void BookmarkSuggestionsProvider::ClearHistory(
base::Time begin,
base::Time end,
const base::Callback<bool(const GURL& url)>& filter) {
- // TODO(vitaliii): Implement. See crbug.com/641321.
+ // TODO(vitaliii): Do not remove all dates, but only the ones matched by the
+ // time range and the filter.
+ RemoveAllLastVisitDates(bookmark_model_);
+ FetchBookmarks();
+ ClearDismissedSuggestionsForDebugging(provided_category_);
Marc Treib 2016/09/01 14:11:20 Should we clear the dismissed first, and then re-f
vitaliii 2016/09/01 14:45:15 Done.
}
void BookmarkSuggestionsProvider::ClearCachedSuggestions(Category category) {

Powered by Google App Engine
This is Rietveld 408576698