third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp - Issue 2303703002: Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

Issue 2303703002: Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: New baselines Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

index f6ec538e69f8a1a51d7a18a1a382d82bab78994c..16f13797ec287d36f890c463af70e246dbcdd4c4 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

@@ -114,7 +114,7 @@ void buildFilterOperations(const FilterOperations& operations, CompositorFilterO

FilterEffect* filterEffect = referenceFilter->lastEffect();

currentColorSpace = filterEffect->operatingColorSpace();

- filterEffect->determineFilterPrimitiveSubregion(MapRectForward);

+ filterEffect->determineMaximumEffectRect(MapRectForward);

filters->appendReferenceFilter(SkiaImageFilterBuilder::build(filterEffect, currentColorSpace));

}

break;