third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp - Issue 2303703002: Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp

Issue 2303703002: Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: Baselines again; Manual for mac10.11-retina Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FETile.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FETile.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp b/third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp

index 3a60a1d421078b56fc428d5e0abbd2f04b43a6a2..31dd6e537a6c123a1d601c098ca045c3d11b8abd 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp

@@ -128,7 +128,9 @@ bool FETurbulence::setStitchTiles(bool stitch)

sk_sp<SkShader> FETurbulence::createShader() const

{

- const SkISize size = SkISize::Make(effectBoundaries().width(), effectBoundaries().height());

+ const SkISize size = SkISize::Make(

+ filterPrimitiveSubregion().width(),

+ filterPrimitiveSubregion().height());

// Frequency should be scaled by page zoom, but not by primitiveUnits.

// So we apply only the transform scale (as Filter::apply*Scale() do)

// and not the target bounding box scale (as SVGFilter::apply*Scale()