Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/cast_certificate/cast_crl.h

Issue 2303673004: Hook up Chrome Cast sender to Cast CRL. (Closed)
Patch Set: VerifyDeviceCertUsingCustomTrustStore and ParseAndVerifyCRLUsingCustomTrustStore Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_crl.h
diff --git a/components/cast_certificate/cast_crl.h b/components/cast_certificate/cast_crl.h
index 0ab6964fa03c25c26bdadea73e601d8b0aa8054b..6bb07365760ffae898bfd65f93d60c9e5f573fe9 100644
--- a/components/cast_certificate/cast_crl.h
+++ b/components/cast_certificate/cast_crl.h
@@ -53,13 +53,16 @@ class CastCRL {
std::unique_ptr<CastCRL> ParseAndVerifyCRL(const std::string& crl_proto,
const base::Time& time);
-// Exposed only for testing, not for use in production code.
-//
// This is an overloaded version of ParseAndVerifyCRL that allows
-// the input of a custom TrustStore.
-std::unique_ptr<CastCRL> ParseAndVerifyCRLForTest(const std::string& crl_proto,
- const base::Time& time,
- net::TrustStore* trust_store);
+// the input of a custom TrustStore. If |trust_store| is nullptr, the default
eroman 2016/09/10 01:03:23 This comment doesn't agree with implementation.
ryanchung 2016/09/14 18:53:39 Done.
+// trust store is used.
+//
+// For production use pass |trust_store| as nullptr to use the production trust
+// store.
+std::unique_ptr<CastCRL> ParseAndVerifyCRLUsingCustomTrustStore(
+ const std::string& crl_proto,
+ const base::Time& time,
+ net::TrustStore* trust_store);
} // namespace cast_certificate

Powered by Google App Engine
This is Rietveld 408576698