Hook up Chrome Cast sender to Cast CRL.

components/cast_certificate/cast_crl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cast_certificate/cast_crl.h"
 
 #include <unordered_map>
 #include <unordered_set>
 
 #include "base/base64.h"
@@ skipping 298 matching lines @@
           }
         }
       }
     }
   }
   return true;
 }
 
 // Parses and verifies the CRL used to verify the revocation status of
 // Cast device certificates.
-std::unique_ptr<CastCRL> ParseAndVerifyCRL(const std::string& crl_proto,
-                                           const base::Time& time,
-                                           net::TrustStore* trust_store) {
+std::unique_ptr<CastCRL> ParseAndVerifyCRLImpl(const std::string& crl_proto,
+                                               const base::Time& time,
+                                               net::TrustStore* trust_store) {
   CrlBundle crl_bundle;
   if (!crl_bundle.ParseFromString(crl_proto)) {
     LOG(ERROR) << "CRL - Binary could not be parsed.";
     return nullptr;
   }
   for (auto const& crl : crl_bundle.crls()) {
     TbsCrl tbs_crl;
     if (!tbs_crl.ParseFromString(crl.tbs_crl())) {
       LOG(WARNING) << "Binary TBS CRL could not be parsed.";
       continue;
     }
     if (tbs_crl.version() != CRL_VERSION_0) {
       continue;
     }
     net::der::GeneralizedTime overall_not_after;
     if (!VerifyCRL(crl, tbs_crl, time, trust_store, &overall_not_after)) {
       LOG(ERROR) << "CRL - Verification failed.";
       return nullptr;
     }
     return base::WrapUnique(new CastCRLImpl(tbs_crl, overall_not_after));
   }
   LOG(ERROR) << "No supported version of revocation data.";
   return nullptr;
 }
 
 }  // namespace
 
 std::unique_ptr<CastCRL> ParseAndVerifyCRL(const std::string& crl_proto,
                                            const base::Time& time) {
-  return ParseAndVerifyCRL(crl_proto, time, &CastCRLTrustStore::Get());
+  return ParseAndVerifyCRLImpl(crl_proto, time, &CastCRLTrustStore::Get());
 }
 
-std::unique_ptr<CastCRL> ParseAndVerifyCRLForTest(
+std::unique_ptr<CastCRL> ParseAndVerifyCRLUsingCustomTrustStore(

[sheretov, 2016/09/10 00:26:57]

Can we eliminate ParseAndVerifyCRLImpl, move all that logic into
ParseAndVerifyCRLUsingCustomTrustStore, and call it from ParseAndVerifyCRL?

[ryanchung, 2016/09/10 00:50:09]

Done.

     const std::string& crl_proto,
     const base::Time& time,
     net::TrustStore* trust_store) {
-  return ParseAndVerifyCRL(crl_proto, time, trust_store);
+  if (!trust_store)
+    return nullptr;
+  return ParseAndVerifyCRLImpl(crl_proto, time, trust_store);
 }
 
 }  // namespace cast_certificate