Hook up Chrome Cast sender to Cast CRL.

components/cast_certificate/cast_cert_validator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cast_certificate/cast_cert_validator.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 237 matching lines @@
   //
   // Allow these sorts of serial numbers.
   //
   // TODO(eroman): At some point in the future this workaround will no longer be
   // necessary. Should revisit this for removal in 2017 if not earlier.
   options.allow_invalid_serial_numbers = true;
   return options;
 }
 
 // Verifies a cast device certficate given a chain of DER-encoded certificates.
-bool VerifyDeviceCert(const std::vector<std::string>& certs,
-                      const base::Time& time,
-                      std::unique_ptr<CertVerificationContext>* context,
-                      CastDeviceCertPolicy* policy,
-                      const CastCRL* crl,
-                      CRLPolicy crl_policy,
-                      net::TrustStore* trust_store) {
+bool VerifyDeviceCertImpl(const std::vector<std::string>& certs,
+                          const base::Time& time,
+                          std::unique_ptr<CertVerificationContext>* context,
+                          CastDeviceCertPolicy* policy,
+                          const CastCRL* crl,
+                          CRLPolicy crl_policy,
+                          net::TrustStore* trust_store) {
   if (certs.empty())
     return false;
 
   // No reference to these ParsedCertificates is kept past the end of this
   // function, so using EXTERNAL_REFERENCE here is safe.
   scoped_refptr<net::ParsedCertificate> target_cert;
   net::CertIssuerSourceStatic intermediate_cert_issuer_source;
   for (size_t i = 0; i < certs.size(); ++i) {
     scoped_refptr<net::ParsedCertificate> cert(
         net::ParsedCertificate::CreateFromCertificateData(
@@ skipping 51 matching lines @@
 }
 
 }  // namespace
 
 bool VerifyDeviceCert(const std::vector<std::string>& certs,
                       const base::Time& time,
                       std::unique_ptr<CertVerificationContext>* context,
                       CastDeviceCertPolicy* policy,
                       const CastCRL* crl,
                       CRLPolicy crl_policy) {
-  return VerifyDeviceCert(certs, time, context, policy, crl, crl_policy,
-                          &CastTrustStore::Get());
+  return VerifyDeviceCertImpl(certs, time, context, policy, crl, crl_policy,

[sheretov, 2016/09/10 00:26:57]

Same comment as in cast_crl.cc: seems like we could eliminate the "Impl"
function and use the "UsingCustomTrustStore".

[ryanchung, 2016/09/10 00:50:09]

Done.

+                              &CastTrustStore::Get());
 }
 
-bool VerifyDeviceCertForTest(const std::vector<std::string>& certs,
-                             const base::Time& time,
-                             std::unique_ptr<CertVerificationContext>* context,
-                             CastDeviceCertPolicy* policy,
-                             const CastCRL* crl,
-                             CRLPolicy crl_policy,
-                             net::TrustStore* trust_store) {
-  return VerifyDeviceCert(certs, time, context, policy, crl, crl_policy,
-                          trust_store);
+bool VerifyDeviceCertUsingCustomTrustStore(
+    const std::vector<std::string>& certs,
+    const base::Time& time,
+    std::unique_ptr<CertVerificationContext>* context,
+    CastDeviceCertPolicy* policy,
+    const CastCRL* crl,
+    CRLPolicy crl_policy,
+    net::TrustStore* trust_store) {
+  if (!trust_store)
+    return false;
+  return VerifyDeviceCertImpl(certs, time, context, policy, crl, crl_policy,
+                              trust_store);
 }
 
 std::unique_ptr<CertVerificationContext> CertVerificationContextImplForTest(
     const base::StringPiece& spki) {
   // Use a bogus CommonName, since this is just exposed for testing signature
   // verification by unittests.
   return base::WrapUnique(
       new CertVerificationContextImpl(net::der::Input(spki), "CommonName"));
 }
 
 }  // namespace cast_certificate