Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2303663003: DevTools: fix hosted mode (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix hosted mode This was regressed in crrev.com/2296983003 BUG=none TBR=dgozman Committed: https://chromium.googlesource.com/chromium/src/+/394c7f553cacfab8789777c96bec67e47dcd4613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
that's the fix!
4 years, 3 months ago (2016-09-02 01:44:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303663003/1
4 years, 3 months ago (2016-09-02 01:44:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/286372)
4 years, 3 months ago (2016-09-02 05:06:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303663003/1
4 years, 3 months ago (2016-09-02 16:02:07 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/394c7f553cacfab8789777c96bec67e47dcd4613 Cr-Commit-Position: refs/heads/master@{#416277}
4 years, 3 months ago (2016-09-02 16:10:31 UTC) #9
lushnikov
4 years, 3 months ago (2016-09-02 16:11:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
394c7f553cacfab8789777c96bec67e47dcd4613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698