Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2303543003: Revert of [runtime] temporarily transform IsContext check from DHECK to CHECK (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] temporarily transform IsContext check from DHECK to CHECK (patchset #2 id:20001 of https://codereview.chromium.org/2164633002/ ) Reason for revert: There have been no more occurrences of this on dev / beta so we can convert the CHECK back to DCHECK. Original issue's description: > [runtime] temporarily transform IsContext check from DCHECK to CHECK > > We are enabling this trial on canary to see if we can flush out some missing > context restores. > > BUG= > > Committed: https://crrev.com/ec94ad400dc257af396efa3b1899bc3168347d82 > Cr-Commit-Position: refs/heads/master@{#37875} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/6faf6c1545f71ee8b394f0bb785a41017e804955 Cr-Commit-Position: refs/heads/master@{#39292}

Patch Set 1 #

Patch Set 2 : fixing merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M src/arguments.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 1 chunk +25 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Camillo Bruni
Created Revert of [runtime] temporarily transform IsContext check from DHECK to CHECK
4 years, 3 months ago (2016-09-01 12:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303543003/1
4 years, 3 months ago (2016-09-01 12:30:44 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/23737) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-01 12:32:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303543003/70001
4 years, 3 months ago (2016-09-08 18:00:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 3 months ago (2016-09-08 18:28:06 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:28:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6faf6c1545f71ee8b394f0bb785a41017e804955
Cr-Commit-Position: refs/heads/master@{#39292}

Powered by Google App Engine
This is Rietveld 408576698