Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 23035007: Replace HTMLTextFormControlElement::fixPlaceholderRenderer with an override of RenderTextControl::a… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Just delete the test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index 0ce84dd7c58912af527e853afdf3475802d1bbc2..786bca4fe8e154c9fe981870bb8ea3877a59eca7 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -156,24 +156,6 @@ void HTMLTextFormControlElement::updatePlaceholderVisibility(bool placeholderVal
placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? CSSValueVisible : CSSValueHidden);
}
-void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement)
-{
- // FIXME: We should change the order of DOM nodes. But it makes an assertion
- // failure in editing code.
- if (!placeholder || !placeholder->renderer())
- return;
- RenderObject* placeholderRenderer = placeholder->renderer();
- RenderObject* siblingRenderer = siblingElement->renderer();
- if (!siblingRenderer)
- return;
- if (placeholderRenderer->nextSibling() == siblingRenderer)
- return;
- RenderObject* parentRenderer = placeholderRenderer->parent();
- ASSERT(siblingRenderer->parent() == parentRenderer);
- parentRenderer->removeChild(placeholderRenderer);
- parentRenderer->addChild(placeholderRenderer, siblingRenderer);
-}
-
void HTMLTextFormControlElement::setSelectionStart(int start)
{
setSelectionRange(start, max(start, selectionEnd()), selectionDirection());
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698