Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 23035007: Replace HTMLTextFormControlElement::fixPlaceholderRenderer with an override of RenderTextControl::a… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextAreaElement.cpp
diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp
index 03dd058004c659b8d34719330bf2d35c4a0b1346..128bc3f19c305bc741a1bd5315567c53b8ae0bc7 100644
--- a/Source/core/html/HTMLTextAreaElement.cpp
+++ b/Source/core/html/HTMLTextAreaElement.cpp
@@ -512,12 +512,6 @@ HTMLElement* HTMLTextAreaElement::placeholderElement() const
return m_placeholder;
}
-void HTMLTextAreaElement::attach(const AttachContext& context)
-{
- HTMLTextFormControlElement::attach(context);
- fixPlaceholderRenderer(m_placeholder, innerTextElement());
-}
-
bool HTMLTextAreaElement::matchesReadOnlyPseudoClass() const
{
return isReadOnly();
@@ -544,8 +538,7 @@ void HTMLTextAreaElement::updatePlaceholderText()
m_placeholder->setPart(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));
userAgentShadowRoot()->insertBefore(m_placeholder, innerTextElement()->nextSibling(), ASSERT_NO_EXCEPTION);
}
- m_placeholder->setInnerText(placeholderText, ASSERT_NO_EXCEPTION);
- fixPlaceholderRenderer(m_placeholder, innerTextElement());
+ m_placeholder->setTextContent(placeholderText, ASSERT_NO_EXCEPTION);
}
}

Powered by Google App Engine
This is Rietveld 408576698