Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2303483002: All DCP manager tests that enroll/register are tested with all auths. (Closed)

Created:
4 years, 3 months ago by The one and only Dr. Crash
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

All DCP manager tests that enroll/register are tested with all auths. Use a FakeSigningService in the DeviceCloudPolicyInitializer in order to be able to unit test re-enrollment for locked devices when registering with a certificate. BUG=624187, 641447 TEST=unit_tests TBR=pastarmovj Committed: https://crrev.com/f214f9f74343bf4115c44a4b113ac8a122bdf6c6 Cr-Commit-Position: refs/heads/master@{#415799}

Patch Set 1 #

Patch Set 2 : Fixed memory reuse issue (http://crbug.com/624187). #

Messages

Total messages: 9 (5 generated)
xiyuan
LGTM Let's add link to the previous review in CL description since this is a ...
4 years, 3 months ago (2016-08-31 22:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303483002/20001
4 years, 3 months ago (2016-08-31 22:28:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 23:20:00 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:22:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f214f9f74343bf4115c44a4b113ac8a122bdf6c6
Cr-Commit-Position: refs/heads/master@{#415799}

Powered by Google App Engine
This is Rietveld 408576698