Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2303453003: Revert of Moves ash content specific tests into ash_content_unittests (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, mlamouri+watch-screen-orientation_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moves ash content specific tests into ash_content_unittests (patchset #7 id:120001 of https://codereview.chromium.org/2296973002/ ) Reason for revert: AshTestEnvironmentDefault::GetBlockingPool() never gets released causing memory leaks in tests: WallpaperControllerTest.DontScaleWallpaperWithCenterLayout WallpaperControllerTest.ResizeCustomWallpaper https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15788 https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15787 Original issue's description: > Moves ash content specific tests into ash_content_unittests > > The vast majority of the tests don't need content, so having to build > content all the time is a drain (especially on windows). > > BUG=641026 > TEST=test only changes > R=jamescook@chromium.org, dpranke@chromium.org > > Committed: https://crrev.com/72f7f7e82686a6b2b85341b0dfc3f9f1cf37334e > Cr-Commit-Position: refs/heads/master@{#415743} TBR=reveman@chromium.org,dpranke@chromium.org,jam@chromium.org,jamescook@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641026 Committed: https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446 Cr-Commit-Position: refs/heads/master@{#415797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -554 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/BUILD.gn View 11 chunks +49 lines, -122 lines 0 comments Download
M ash/ash.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/DEPS View 1 chunk +4 lines, -8 lines 0 comments Download
M ash/test/ash_test_base.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D ash/test/ash_test_environment.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/test/ash_test_environment_content.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ash/test/ash_test_environment_content.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ash/test/ash_test_environment_default.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M ash/test/ash_test_helper.h View 7 chunks +23 lines, -5 lines 0 comments Download
M ash/test/ash_test_helper.cc View 10 chunks +19 lines, -10 lines 0 comments Download
M ash/test/ash_test_helper_unittest.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M ash/test/ash_test_views_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/test/ash_test_views_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download
D ash/test/content/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +3 lines, -7 lines 0 comments Download
D chrome/test/base/ash_test_environment_chrome.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/base/ash_test_environment_chrome.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/exo/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fgorski
Created Revert of Moves ash content specific tests into ash_content_unittests
4 years, 3 months ago (2016-08-31 23:15:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303453003/1
4 years, 3 months ago (2016-08-31 23:16:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 23:17:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4feb9f49a25aadfd400798be8c767d8b272ac446 Cr-Commit-Position: refs/heads/master@{#415797}
4 years, 3 months ago (2016-08-31 23:19:39 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-08-31 23:44:56 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698