Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: content/browser/loader/mime_sniffing_resource_handler.cc

Issue 2303443005: Send an image-like 'Accept' header for favicons. (Closed)
Patch Set: Test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/loader/mime_sniffing_resource_handler_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/mime_sniffing_resource_handler.h" 5 #include "content/browser/loader/mime_sniffing_resource_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 bool MimeSniffingResourceHandler::OnWillStart(const GURL& url, bool* defer) { 99 bool MimeSniffingResourceHandler::OnWillStart(const GURL& url, bool* defer) {
100 const char* accept_value = nullptr; 100 const char* accept_value = nullptr;
101 switch (GetRequestInfo()->GetResourceType()) { 101 switch (GetRequestInfo()->GetResourceType()) {
102 case RESOURCE_TYPE_MAIN_FRAME: 102 case RESOURCE_TYPE_MAIN_FRAME:
103 case RESOURCE_TYPE_SUB_FRAME: 103 case RESOURCE_TYPE_SUB_FRAME:
104 accept_value = kFrameAcceptHeader; 104 accept_value = kFrameAcceptHeader;
105 break; 105 break;
106 case RESOURCE_TYPE_STYLESHEET: 106 case RESOURCE_TYPE_STYLESHEET:
107 accept_value = kStylesheetAcceptHeader; 107 accept_value = kStylesheetAcceptHeader;
108 break; 108 break;
109 case RESOURCE_TYPE_FAVICON:
109 case RESOURCE_TYPE_IMAGE: 110 case RESOURCE_TYPE_IMAGE:
110 accept_value = kImageAcceptHeader; 111 accept_value = kImageAcceptHeader;
111 break; 112 break;
112 case RESOURCE_TYPE_SCRIPT: 113 case RESOURCE_TYPE_SCRIPT:
113 case RESOURCE_TYPE_FONT_RESOURCE: 114 case RESOURCE_TYPE_FONT_RESOURCE:
114 case RESOURCE_TYPE_SUB_RESOURCE: 115 case RESOURCE_TYPE_SUB_RESOURCE:
115 case RESOURCE_TYPE_OBJECT: 116 case RESOURCE_TYPE_OBJECT:
116 case RESOURCE_TYPE_MEDIA: 117 case RESOURCE_TYPE_MEDIA:
117 case RESOURCE_TYPE_WORKER: 118 case RESOURCE_TYPE_WORKER:
118 case RESOURCE_TYPE_SHARED_WORKER: 119 case RESOURCE_TYPE_SHARED_WORKER:
119 case RESOURCE_TYPE_PREFETCH: 120 case RESOURCE_TYPE_PREFETCH:
120 case RESOURCE_TYPE_FAVICON:
121 case RESOURCE_TYPE_XHR: 121 case RESOURCE_TYPE_XHR:
122 case RESOURCE_TYPE_PING: 122 case RESOURCE_TYPE_PING:
123 case RESOURCE_TYPE_SERVICE_WORKER: 123 case RESOURCE_TYPE_SERVICE_WORKER:
124 case RESOURCE_TYPE_CSP_REPORT: 124 case RESOURCE_TYPE_CSP_REPORT:
125 case RESOURCE_TYPE_PLUGIN_RESOURCE: 125 case RESOURCE_TYPE_PLUGIN_RESOURCE:
126 accept_value = kDefaultAcceptHeader; 126 accept_value = kDefaultAcceptHeader;
127 break; 127 break;
128 case RESOURCE_TYPE_LAST_TYPE: 128 case RESOURCE_TYPE_LAST_TYPE:
129 NOTREACHED(); 129 NOTREACHED();
130 break; 130 break;
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 509
510 void MimeSniffingResourceHandler::OnPluginsLoaded( 510 void MimeSniffingResourceHandler::OnPluginsLoaded(
511 const std::vector<WebPluginInfo>& plugins) { 511 const std::vector<WebPluginInfo>& plugins) {
512 // No longer blocking on the plugins being loaded. 512 // No longer blocking on the plugins being loaded.
513 request()->LogUnblocked(); 513 request()->LogUnblocked();
514 if (state_ == STATE_BUFFERING) 514 if (state_ == STATE_BUFFERING)
515 AdvanceState(); 515 AdvanceState();
516 } 516 }
517 517
518 } // namespace content 518 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/loader/mime_sniffing_resource_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698