third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp - Issue 2303443003: CSS: Additional asserts for style invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

Issue 2303443003: CSS: Additional asserts for style invalidation (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h ('K') | « third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

diff --git a/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp b/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

index 18d29abe552fb900fc462fb563ab51613d222661..fa14a01c6dcb837794380913f8f02e859fc9028f 100644

--- a/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

+++ b/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

@@ -104,7 +104,9 @@ bool InvalidationSet::invalidatesElement(Element& element) const

void InvalidationSet::combine(const InvalidationSet& other)

{

- ASSERT(type() == other.type());

+ RELEASE_ASSERT(m_isAlive);

+ RELEASE_ASSERT(other.m_isAlive);

+ RELEASE_ASSERT(type() == other.type());

if (type() == InvalidateSiblings) {

SiblingInvalidationSet& siblings = toSiblingInvalidationSet(*this);

const SiblingInvalidationSet& otherSiblings = toSiblingInvalidationSet(other);