CSS: Additional asserts for style invalidation

third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 86 matching lines @@
                 return true;
             }
         }
     }
 
     return false;
 }
 
 void InvalidationSet::combine(const InvalidationSet& other)
 {
-    ASSERT(type() == other.type());
+    RELEASE_ASSERT(m_isAlive);
+    RELEASE_ASSERT(other.m_isAlive);
+    RELEASE_ASSERT(&other != this);
+    RELEASE_ASSERT(type() == other.type());
     if (type() == InvalidateSiblings) {
         SiblingInvalidationSet& siblings = toSiblingInvalidationSet(*this);
         const SiblingInvalidationSet& otherSiblings = toSiblingInvalidationSet(other);
 
         siblings.updateMaxDirectAdjacentSelectors(otherSiblings.maxDirectAdjacentSelectors());
         if (otherSiblings.siblingDescendants())
             siblings.ensureSiblingDescendants().combine(*otherSiblings.siblingDescendants());
         if (otherSiblings.descendants())
             siblings.ensureDescendants().combine(*otherSiblings.descendants());
     }
@@ skipping 76 matching lines @@
 {
     if (!m_attributes)
         m_attributes = wrapUnique(new HashSet<AtomicString>);
     return *m_attributes;
 }
 
 void InvalidationSet::addClass(const AtomicString& className)
 {
     if (wholeSubtreeInvalid())
         return;
+    RELEASE_ASSERT(!className.isEmpty());
     ensureClassSet().add(className);
 }
 
 void InvalidationSet::addId(const AtomicString& id)
 {
     if (wholeSubtreeInvalid())
         return;
+    RELEASE_ASSERT(!id.isEmpty());
     ensureIdSet().add(id);
 }
 
 void InvalidationSet::addTagName(const AtomicString& tagName)
 {
     if (wholeSubtreeInvalid())
         return;
+    RELEASE_ASSERT(!tagName.isEmpty());
     ensureTagNameSet().add(tagName);
 }
 
 void InvalidationSet::addAttribute(const AtomicString& attribute)
 {
     if (wholeSubtreeInvalid())
         return;
+    RELEASE_ASSERT(!attribute.isEmpty());
     ensureAttributeSet().add(attribute);
 }
 
 void InvalidationSet::setWholeSubtreeInvalid()
 {
     if (m_allDescendantsMightBeInvalid)
         return;
 
     m_allDescendantsMightBeInvalid = true;
     m_customPseudoInvalid = false;
@@ skipping 80 matching lines @@
 }
 
 DescendantInvalidationSet& SiblingInvalidationSet::ensureDescendants()
 {
     if (!m_descendantInvalidationSet)
         m_descendantInvalidationSet = DescendantInvalidationSet::create();
     return *m_descendantInvalidationSet;
 }
 
 } // namespace blink