CSS: Additional asserts for style invalidation

third_party/WebKit/Source/core/css/RuleFeature.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 105 matching lines @@
 
     bool isAlive() const { return m_isAlive; }
 
 protected:
     InvalidationSet* invalidationSetForSelector(const CSSSelector&, InvalidationType);
 
 private:
     // Each map entry is either a DescendantInvalidationSet or SiblingInvalidationSet.
     // When both are needed, we store the SiblingInvalidationSet, and use it to hold the DescendantInvalidationSet.
     using InvalidationSetMap = HashMap<AtomicString, RefPtr<InvalidationSet>>;
-    using PseudoTypeInvalidationSetMap = HashMap<CSSSelector::PseudoType, RefPtr<InvalidationSet>, WTF::IntHash<unsigned>, WTF::UnsignedWithZeroKeyHashTraits<unsigned>>;
+    using PseudoTypeInvalidationSetMap = HashMap<int, RefPtr<InvalidationSet>>; // key values are CSSSelector::PseudoType

[esprehn, 2016/09/01 05:30:22]

Does this need changing in this patch?

[Eric Willigers, 2016/09/01 14:56:31]

No, we can focus on non-zero keys in this patch.

 
     struct FeatureMetadata {
         DISALLOW_NEW();
         void add(const FeatureMetadata& other);
         void clear();
 
         bool usesFirstLineRules = false;
         bool usesWindowInactiveSelector = false;
         bool foundSiblingSelector = false;
         bool foundInsertionPointCrossing = false;
@@ skipping 54 matching lines @@
 
     // If true, the RuleFeatureSet is alive and can be used.
     unsigned m_isAlive : 1;
 
     friend class RuleFeatureSetTest;
 };
 
 } // namespace blink
 
 #endif // RuleFeature_h