[Offline pages] Reenabling sharing tests

[Offline pages] Reenabling sharing tests

This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation
to make it more reliable (by ensuring a more proper clean up).

BUG=640319
patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1)

Committed: https://crrev.com/81804dcb67f03f8852af065bfc3be224bb68c2d5
Cr-Commit-Position: refs/heads/master@{#415784}

[fgorski, 2016-08-31 21:06:29]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:06:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-31 21:07:29]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org

[fgorski, 2016-08-31 21:07:30]

PTAL

[jianli, 2016-08-31 21:12:28]

lgtm

https://codereview.chromium.org/2303443002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
(right):

https://codereview.chromium.org/2303443002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:305:
assertFalse("Cache directory should be deleted.", offlineCacheDir.exists());
This assert seems not to be necessary since an exception should be thrown in
calling clearSharedOfflineFilesAndWait.

[fgorski, 2016-08-31 21:33:37]

Addressed and renamed vars/updated comments.

https://codereview.chromium.org/2303443002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
(right):

https://codereview.chromium.org/2303443002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:305:
assertFalse("Cache directory should be deleted.", offlineCacheDir.exists());
On 2016/08/31 21:12:28, jianli wrote:
> This assert seems not to be necessary since an exception should be thrown in
> calling clearSharedOfflineFilesAndWait.

Done.

[fgorski, 2016-08-31 21:38:18]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:16:05]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-31 22:22:43]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-08-31 22:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jianli@chromium.org
Link to the patchset: https://codereview.chromium.org/2303443002/#ps40001
(title: "Fixing a typo")

[commit-bot: I haz the power, 2016-08-31 22:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:31:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 22:32:41]

Description was changed from

==========
[Offline pages] Reenabling sharing tests

This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation
to make it more reliable (by ensuring a more proper clean up).

BUG=640319

patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1)
==========

to

==========
[Offline pages] Reenabling sharing tests

This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation
to make it more reliable (by ensuring a more proper clean up).

BUG=640319

patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1)

Committed: https://crrev.com/81804dcb67f03f8852af065bfc3be224bb68c2d5
Cr-Commit-Position: refs/heads/master@{#415784}
==========

[commit-bot: I haz the power, 2016-08-31 22:32:42]

Patchset 3 (id:??) landed as
https://crrev.com/81804dcb67f03f8852af065bfc3be224bb68c2d5
Cr-Commit-Position: refs/heads/master@{#415784}