ios/chrome/browser/interstitials/ios_security_interstitial_page.mm - Issue 2303413002: Simplify security_interstitials::ControllerClient and other related classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/interstitials/ios_security_interstitial_page.mm

Issue 2303413002: Simplify security_interstitials::ControllerClient and other related classes (Closed)

Patch Set: Jialiu comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/interstitials/ios_security_interstitial_page.mm

diff --git a/ios/chrome/browser/interstitials/ios_security_interstitial_page.mm b/ios/chrome/browser/interstitials/ios_security_interstitial_page.mm

index dc9158af564e95ff39dd8902c1f85d870cdd0af2..496e9e96139e769db177cac515a1811300fe30f2 100644

--- a/ios/chrome/browser/interstitials/ios_security_interstitial_page.mm

+++ b/ios/chrome/browser/interstitials/ios_security_interstitial_page.mm

@@ -8,10 +8,8 @@

#include "components/grit/components_resources.h"

#include "components/prefs/pref_service.h"

#include "components/security_interstitials/core/common_string_util.h"

-#include "components/security_interstitials/core/metrics_helper.h"

#include "ios/chrome/browser/application_context.h"

#include "ios/chrome/browser/browser_state/chrome_browser_state.h"

-#include "ios/chrome/browser/interstitials/ios_chrome_controller_client.h"

#include "ios/chrome/browser/pref_names.h"

#include "ios/web/public/interstitials/web_interstitial.h"

#include "ios/web/public/web_state/web_state.h"