chrome/browser/ssl/ssl_browser_tests.cc - Issue 2303413002: Simplify security_interstitials::ControllerClient and other related classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2303413002: Simplify security_interstitials::ControllerClient and other related classes (Closed)

Patch Set: Rebase 2 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 61d20c548a72f244d88b7b65100951296aedd8f1..6d6db236ae337c770b389fab39e641620e527823 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -3077,7 +3077,7 @@ class SSLBlockingPageIDNTest : public SecurityInterstitialIDNTest {

net::SSLInfo ssl_info;

ssl_info.cert =

net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem");

- return new SSLBlockingPage(

+ return SSLBlockingPage::Create(

contents, net::ERR_CERT_CONTAINS_ERRORS, ssl_info, request_url, 0,

base::Time::NowFromSystemTime(), nullptr,

base::Callback<void(content::CertificateRequestResultType)>());