Simplify security_interstitials::ControllerClient and other related classes

components/security_interstitials/core/controller_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_
 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 38 matching lines @@
   CMD_OPEN_WHITEPAPER = 11,
   // Report a phishing error
   CMD_REPORT_PHISHING_ERROR = 12,
 };
 
 // Provides methods for handling commands from the user, which requires some
 // embedder-specific abstraction. This class should handle all commands sent
 // by the JavaScript error page.
 class ControllerClient {
  public:
-  ControllerClient();
+  explicit ControllerClient(std::unique_ptr<MetricsHelper> metrics_helper);
   virtual ~ControllerClient();
 
   // Handle the user's reporting preferences.
   void SetReportingPreference(bool report);
   void OpenExtendedReportingPrivacyPolicy();
   void OpenExtendedReportingWhitepaper();
 
   // If available, open the operating system's date/time settings.
   virtual bool CanLaunchDateAndTimeSettings() = 0;
   virtual void LaunchDateAndTimeSettings() = 0;
 
   // Close the error and go back to the previous page.
   virtual void GoBack() = 0;
 
   // Close the error and proceed to the blocked page.
   virtual void Proceed() = 0;
 
   // Reload the blocked page to see if it succeeds now.
   virtual void Reload() = 0;
 
   MetricsHelper* metrics_helper() const;
-  void set_metrics_helper(std::unique_ptr<MetricsHelper> metrics_helper);
 
   virtual void OpenUrlInCurrentTab(const GURL& url) = 0;
 
  protected:
   virtual const std::string& GetApplicationLocale() = 0;
   virtual PrefService* GetPrefService() = 0;
   virtual const std::string GetExtendedReportingPrefName() = 0;
 
  private:
   std::unique_ptr<MetricsHelper> metrics_helper_;
 
   DISALLOW_COPY_AND_ASSIGN(ControllerClient);
 };
 
 }  // namespace security_interstitials
 
 #endif  // COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_