Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: components/tracing/proto/event.proto

Issue 2303353002: Tracing v2: wire up stubs generated by the protozero protoc plugin (Closed)
Patch Set: petrcermak review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/proto/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/proto/event.proto
diff --git a/components/tracing/proto/event.proto b/components/tracing/proto/event.proto
index 4be1b47ed846ecd97711d2e0a7d4a3202117d59a..24bb7ad93ce1f16e95b5d86a1ca4151ea29631b4 100644
--- a/components/tracing/proto/event.proto
+++ b/components/tracing/proto/event.proto
@@ -7,6 +7,29 @@ option optimize_for = LITE_RUNTIME;
package tracing.proto;
+// Note on field numbers: fields in the range [1, 15] can be encoded using a
+// single byte preamble. Hence they should be used only for the most commonly
+// used fields (to save trace size). Use the range 16+ for fields that are not
+// expected to be used frequently.
message Event {
- // TODO(kraynov): Make proto definitions.
+ // Using ASCII codes as enum values, according to the legacy phase arguments
+ // ("ph") of the Trace Event Format doc (https://goo.gl/mSXylN).
+ enum EventType {
+ METADATA = 77; // = 'M'.
+ COMPLETE = 88; // = 'X'.
+ };
+
+ optional EventType type = 1;
+
+ oneof name {
+ int64 name_id = 2;
+ string name_str = 16;
+ }
+
+ optional int64 category_id = 4;
+
+ optional uint64 timestamp = 5;
+ optional uint64 thread_timestamp = 6;
+
+ // TODO(primiano,kraynov): Add args and further fields in next CLs.
}
« no previous file with comments | « components/tracing/proto/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698