Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2303303002: Revert of Force SkPath::getConvexity() cache for thread safety. (Closed)

Created:
4 years, 3 months ago by mtklein
Modified:
4 years, 3 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Force SkPath::getConvexity() cache for thread safety. (patchset #1 id:1 of https://codereview.chromium.org/2300003003/ ) Reason for revert: I don't see anything else in the roll that could have caused the diff. Original issue's description: > Force SkPath::getConvexity() cache for thread safety. > > I happened to stumble on this in a run of TSAN: > https://luci-milo.appspot.com/swarming/task/30fffe9497dc6310/steps/dm/0/stdout > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300003003 > > Committed: https://skia.googlesource.com/skia/+/d0634eeb565d706df2e148a33f137c6edf42bf2e TBR=reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/df0e3ece70762fd4674e09e457e5accb4265995d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/core/SkLiteDL.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkRecords.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Force SkPath::getConvexity() cache for thread safety.
4 years, 3 months ago (2016-09-02 13:51:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303303002/1
4 years, 3 months ago (2016-09-02 13:51:53 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 13:51:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/df0e3ece70762fd4674e09e457e5accb4265995d

Powered by Google App Engine
This is Rietveld 408576698